This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH PING]: middle-end: provide generic "isnormal" transformation


On Sun, 8 Jul 2007, Richard Guenther wrote:

> On 7/8/07, Kaveh R. GHAZI <ghazi@caip.rutgers.edu> wrote:
> > PING.
> >
> > http://gcc.gnu.org/ml/gcc-patches/2007-06/msg01292.html
> >
> > This patch WILL generate incorrect code for certain subnormal numbers.
> > However that problem is fixed by my "type generic" builtins patch here:
> > http://gcc.gnu.org/ml/gcc-patches/2007-07/msg00691.html
> >
> > There's nothing wrong with this patch per se, so it can be reviewed now
> > with the understanding that I'll apply it after the fix above and switch
> > it's attributes to include "type generic".
>
> Same as for the other.  The builtin should be C99_C90RES (if it is reserved
> by C90).  I'm not sure why all of the comparison ones are not - Joseph?
>
> Otherwise ok with documentation in extend.texi.

(I got a vacation auto-reply from Joseph, so he may not reply for a few
weeks.)

He explained to me the reason for using DEF_GCC_BUILTIN here:
http://gcc.gnu.org/ml/gcc-patches/2007-06/msg01364.html

So I'll add docs and resubmit.

		Thanks,
		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]