This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR testsuite/25241 last manual fixes
- From: "Manuel López-Ibáñez" <lopezibanez at gmail dot com>
- To: janis187 at us dot ibm dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 8 Jul 2007 11:24:19 +0100
- Subject: Re: PR testsuite/25241 last manual fixes
- References: <1183763410.7905.28.camel@janis-laptop>
On 07/07/07, Janis Johnson <janis187@us.ibm.com> wrote:
This is OK. Sorry, I hadn't noticed earlier that you were
looking for an approval for this patch.
Thanks.
At some point I'd like to make sure that when there are checks
for multiple messages for the same line that each of those
checks has a unique comment string, to avoid duplicate PASS/FAIL
messages. If it's convenient please add those to the tests with
multiple checks per line, otherwise I'll get them later.
If there is no comment or empty string "", print the regexp. The
regexp should be different, otherwise that testcase is wrong.
Do you think that will be difficult to implement? I think this is the
best solution. Adding comments is annoying and they generally don't
give any useful info.
Also, using "|" in the regexp is BAD. If you need to match several
different messages, use different dg-* directives.
But I can't help on this. I want to finish with PR25241 (2 more
patches to go!) and focus on my Summer of Code project that is very
far behind.
Cheers,
Manuel