This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re:Patch: PR preprocessor/19753
- From: Geoff Keating <geoffk at apple dot com>
- To: tromey at redhat dot com
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 5 Jul 2007 16:34:38 -0700
- Subject: Re:Patch: PR preprocessor/19753
Hi Tom,
PR preprocessor/19753:
* c-opts.c (finish_options): Don't localize "<built-in>" or
"<command-line>".
I'm not sure about the idea of this patch. These really are used in
user messages, for example
$ gcc-4.0 -DFOO=1 -DFOO=2 ~/hello.c -S
<command line>:1:1: warning: "FOO" redefined
<command line>:1:1: warning: this is the location of the previous
definition
and so I think it would be nice if they are localised. I think we
should keep the English representation internally and in .i files, but
detect these specific strings when actually outputting a message and
localise them then.