This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: MIPS object attributes
- From: Richard Sandiford <rsandifo at nildram dot co dot uk>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 30 Jun 2007 20:44:24 +0100
- Subject: Re: MIPS object attributes
- References: <Pine.LNX.4.64.0706301628520.18962@digraph.polyomino.org.uk>
"Joseph S. Myers" <joseph@codesourcery.com> writes:
> 2007-06-30 Joseph Myers <joseph@codesourcery.com>
>
> * configure.ac: Check for .gnu_attribute on MIPS.
> * configure, config.in: Regenerate.
> * config/mips/mips.c (mips_file_start): If supported, output
> attribute for floating-point ABI.
Looks good, thanks. OK with one change:
> +#ifdef HAVE_AS_GNU_ATTRIBUTE
> + fprintf (asm_out_file, "\t.gnu_attribute 4, %d\n",
> + TARGET_HARD_FLOAT ? (TARGET_DOUBLE_FLOAT ? 1 : 2) : 3);
> +#endif
This should be TARGET_HARD_FLOAT_ABI rather than TARGET_HARD_FLOAT.
I'd prefer something without preprocessor conditionals if its easy to
arrange though, especially since we're likely to end up with several
things dependent on HAVE_AS_GNU_ATTRIBUTE.
Richard