This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Tuples] Cleaned up accessor patch.

From: Aldy Hernandez <aldyh at redhat dot com>
To: Diego Novillo <dnovillo at google dot com>
Cc: Christopher Matthews <chrismatthews at google dot com>, gcc-patches at gcc dot gnu dot org
Date: Mon, 25 Jun 2007 09:29:34 -0600
Subject: Re: [Tuples] Cleaned up accessor patch.
References: <5794c4c80706221010r38754e7cvf037467650a9d45e@mail.gmail.com> <467C1D50.8010400@google.com> <5794c4c80706221313l2d6f15cdr68fb1879f9788858@mail.gmail.com> <467FCA98.6010309@google.com>

> Looks fine to me.  If we later realize that the iterator should hold a
> gimple * instead of gimple, we can change it again.

I assume you're talking about "gimple *ptr" in gimple_stmt_iterator.

We had a pointer there so gsi_stmt_ptr() would work, but Richard had
mentioned that there probably wasn't any point to gsi_stmt_ptr since we
couldn't replace statements anymore by storing into them.

I put a FIXME note on gsi_stmt_ptr, and left it there in case we needed
it.

If you also agree we won't need it, I say nuke it.  Please adjust
everything accordingly in gimple-iterator.*, and make sure you run cc1
over all the gimple tests in gcc.dg/gimple/.

Aldy

References:
- [Tuples] Cleaned up accessor patch.
  - From: Christopher Matthews
- Re: [Tuples] Cleaned up accessor patch.
  - From: Diego Novillo
- Re: [Tuples] Cleaned up accessor patch.
  - From: Diego Novillo

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]