This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] m68k.c: Fix build.



On Mon, 18 Jun 2007, Roman Zippel wrote:

> Hi,
> 
> On Tue, 12 Jun 2007, Kazu Hirata wrote:
> 
> > Hi Roman,
> > 
> > Your patch seems to work fine with one tweak.
> > 
> > >  /* 1 if X is an fp register.  */
> > >  #define FP_REG_P(X)	(REG_P (X) && FP_REGNO_P (REGNO (X)))
> > 
> > FP_REG_P in mainline is defined as:
> > 
> >   #define FP_REG_P(X) (REG_P (X) && REGNO_OK_FOR_FP_P (REGNO (X)))
> > 
> > So you need to update the FP_REG definition.  I suppose your patch is not
> > generated against the current mainline!?
> 
> Indeed, I already changed FP_REG_P in separate patch, the patch below 
> pulls it all together.
> gcc currently doesn't bootstrap, so it's only tested via cross compile 
> (but even there the patch is needed due to the reg_renumber problem).
> 
> bye, Roman
> 
> 
> 200x-xx-xx  Roman Zippel <zippel@linux-m68k.org>
> 
> 	* config/m68k/m68k.h (DATA_REGNO_P,ADDRESS_REGNO_P,INT_REGNO_P,
> 	FP_REGNO_P): Use IN_RANGE.
> 	(REGNO_OK_FOR_DATA_P,REGNO_OK_FOR_FP_P): Remove.
> 	(REGNO_OK_FOR_INDEX_NONSTRICT_P,REGNO_OK_FOR_BASE_NONSTRICT_P): New.
> 	(DATA_REG_P): Use DATA_REGNO_P.
> 	(FP_REG_P): Use FP_REGNO_P.
> 	(ADDRESS_REG_P): Use ADDRESS_REGNO_P.
> 	* config/m68k/m68k.c (m68k_legitimate_base_reg_p): Use
> 	REGNO_OK_FOR_INDEX_NONSTRICT_P, REGNO_OK_FOR_BASE_NONSTRICT_P.

Ping?

In the meantime I fully tested the patch and it's needed to bootstrap.

bye, Roman


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]