This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR 32460 - Check PRIVATE attribute for derived components
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Bernhard Fischer <rep dot dot dot nop at gmail dot com>
- Cc: Tobias Burnus <burnus at net-b dot de>, "'fortran at gcc dot gnu dot org'" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 24 Jun 2007 09:09:31 -0700
- Subject: Re: [Patch, Fortran] PR 32460 - Check PRIVATE attribute for derived components
- References: <467D4555.7080706@net-b.de> <20070623195127.GN4096@aon.at> <467DBB96.4080805@net-b.de> <20070624095101.GT4096@aon.at>
On Sun, Jun 24, 2007 at 11:51:01AM +0200, Bernhard Fischer wrote:
> On Sun, Jun 24, 2007 at 02:32:22AM +0200, Tobias Burnus wrote:
> >Bernhard Fischer wrote:
> >>> + int private_comp = 0;
> >>>
> >> bool?
> >>
> >Good idea. I had somehow back in my mind that the GCC source does not
> >use bool as they were added quite late to the C standard (similar like
> >not using C99's // comments). But as bool is already used more than 300
> >times it surely must work. Thanks for pointing out!
> >
> >Would like like to formally review the patch - or did you do so alreay
> >and only forgot the "Ok"?
>
> I did not really review the patch, just glanced over it. Sounds about ok
> but i did not follow the logic closely, so i cannot really say anything
> about it.
OK for trunk.
--
Steve