This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] RIP convert_parm_for_inlining, fix PR29478, PR16876
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org, joseph at codesourcery dot com
- Date: Sat, 23 Jun 2007 11:40:43 -0600
- Subject: Re: [PATCH] RIP convert_parm_for_inlining, fix PR29478, PR16876
- References: <Pine.LNX.4.64.0706231121540.24708@zhemvz.fhfr.qr>
Richard Guenther wrote:
> This final patch gets rid of the convert_parm_for_inlining and its
> side effects which caused some warning and rejects-valid regressions
> (see PR29478, PR16876). It removes the need of the langhook by
> checking that function arguments are suitably promoted at gimplification
> time and if not, mark the call expression so that we later do not try
> to inline it.
> I can approve the middle-end parts myself, but the hook removal from
> the C frontend needs approval, so, ok for mainline?
OK.
> ! /*gcc_assert (times);*/
Remove the assert, or leave it in; don't comment it out, please.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713