Re: Patch to provide infrastructure for parameter lists

[Mark Mitchell <mark at codesourcery dot com>]

Sebastian Pop wrote:
>> 2007-06-20  Michael Meissner  <michael.meissner@amd.com>
>>
>>         * tree.h (function_args_iterator): New type to iterate over
>>         function arguments.
>>         (FOREACH_FUNCTION_ARGS{,_PTR}): Iterator macros for iterating
>> over
>>         function arguments.
>>         (function_args_iter_{init,cond_ptr,cond,next}): New inline
> 
> For the formating of the changelog, I think that it is better to avoid
> compressing
> the name of the functions like this, as it will be difficult to search
> for one of these
> names with a grep ChangeLog*

Yes, the function names should be fully spelled out.

For:

+ /* Return true if TYPE has a variable argument list.  */
+
+ bool
+ stdarg_p (tree fntype)

I think the comment should say, just for clarity:

  /* Return true if TYPE is a prototyped function with a variable
argument list.  In C, this function will return true for "void f(int,
...)", but not "void f()".  */

Please leave num_parm_types and alloc_parm_types out of the patch until
they are needed.

This patch is OK after the freeze.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713