This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tuples] constructors and gs_cond
- From: Aldy Hernandez <aldyh at redhat dot com>
- To: Diego Novillo <dnovillo at google dot com>
- Cc: amacleod at redhat dot com, gcc-patches at gcc dot gnu dot org
- Date: Fri, 22 Jun 2007 06:37:58 -0600
- Subject: Re: [tuples] constructors and gs_cond
- References: <20070621224902.GA12879@redhat.com> <467B2A7D.6090400@google.com>
On Thu, Jun 21, 2007 at 09:48:45PM -0400, Diego Novillo wrote:
> On 6/21/07 6:49 PM, Aldy Hernandez wrote:
>
> > @@ -493,10 +487,6 @@ gs_assign_unary_rhs (gimple gs)
> > static inline void
> > gs_assign_unary_set_rhs (gimple gs, tree rhs)
> > {
> > -#if defined ENABLE_CHECKING
> > - enum gimple_statement_structure_enum gss = gss_for_assign (TREE_CODE (rhs));
> > - gcc_assert (gss = GSS_ASSIGN_UNARY_REG || gss == GSS_ASSIGN_UNARY_MEM);
> > -#endif
>
> Why wouldn't this work? Likewise for the other asserts you removed. If
> we call gss_for_assign, it should work, right?
Wooops, I got trigger happy.
I'll call gss_for_assign in the ones that were working, and commit.
Thanks for pointing this out.