This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Rename tree_ssa_useless_type_conversion_1
- From: Diego Novillo <dnovillo at google dot com>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org, mark at codesourcery dot com
- Date: Fri, 22 Jun 2007 07:38:09 -0400
- Subject: Re: [PATCH] Rename tree_ssa_useless_type_conversion_1
- References: <Pine.LNX.4.64.0706221131410.24708@zhemvz.fhfr.qr>
On 6/22/07 5:35 AM, Richard Guenther wrote:
> *** gcc.orig/tree-cfg.c 2007-06-21 16:54:03.000000000 +0200
> --- gcc/tree-cfg.c 2007-06-21 16:54:16.000000000 +0200
> *************** verify_expr (tree *tp, int *walk_subtree
> *** 3287,3294 ****
> }
> /* Check to make sure the second operand is an integer with type of
> sizetype. */
> ! if (!tree_ssa_useless_type_conversion_1 (sizetype,
> ! TREE_TYPE (TREE_OPERAND (t, 1))))
> {
> error ("invalid operand to pointer plus, second operand is not an "
> "integer with type of sizetype.");
> --- 3287,3294 ----
> }
> /* Check to make sure the second operand is an integer with type of
> sizetype. */
> ! if (!!type_conversion_needed_p (sizetype,
> ! TREE_TYPE (TREE_OPERAND (t, 1))))
No double negation, please.
Other than that, it looks fine to me, but it may be better to wait until
the freeze. Renaming tree_ssa_useless_type_conversion comes in another
patch?