This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tuples] Add gimple-pretty-print.o and misc fixes
- From: Diego Novillo <dnovillo at google dot com>
- To: Aldy Hernandez <aldyh at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Christopher Matthews <chrismatthews at google dot com>
- Date: Thu, 21 Jun 2007 21:47:08 -0400
- Subject: Re: [tuples] Add gimple-pretty-print.o and misc fixes
- References: <467AD652.8010002@google.com> <20070621222720.GA11462@redhat.com>
On 6/21/07 6:27 PM, Aldy Hernandez wrote:
>> +gs_assign_binary_rhs1 (gimple gs)
>> {
>> + gcc_assert (GS_SUBCODE_FLAGS (gs) == GSS_ASSIGN_BINARY);
>> return gs_assign_operand (gs, 1);
>
> The subcode for GS_ASSIGN tuples are the TREE_CODE of the corresponding
> operation, not a GSS_* enum. So in "c = a + b", the SUBCODE_FLAGS
> should be PLUS_EXPR, not GSS_ASSIGN_BINARY.
>
Drat, I missed that one.
> Do you mind if I delete all these assertions?
Actually, let's do what I did in the gs_assign_unary_rhs and call
gss_for_assign to assert that it returns GSS_ASSIGN_BINARY. I bracketed
that with ENABLE_CHECKING.