This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, sh] interrupt_handler fix
- From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- To: christian dot bruel at st dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 21 Jun 2007 08:58:04 +0900 (JST)
- Subject: Re: [PATCH, sh] interrupt_handler fix
- References: <46793E8E.3070105@st.com>
Christian BRUEL <christian.bruel@st.com> wrote:
> 2007-06-20 Christian Bruel <christian.bruel@st.com>
>
> * testsuite/gcc.dg/attr-isr.c: Test delay slot content.
> * config/sh/sh-protos.h (sh_loads_bankedreg_p): New function.
> * config/sh/sh.c (sh_loads_bankedreg_p): Define.
> (push_regs): Changed saving order or banked registers.
> (sh_expand_epilogue): Likewise.
> * config/sh/sh.h (BANKED_REGISTER_P): New macro.
> (FIRST_BANKED_REG): Likewise.
> (LAST_BANKED_REG): Likewise.
> * config/sh/sh.md (banked) New attribute.
> (in_delay_slot): Check banked attribute.
This patch looks fine except a line of the ChangeLog entry:
> * testsuite/gcc.dg/attr-isr.c: Test delay slot content.
which should go to gcc/testsuite/ChangeLog without testsuite/ in
its path. Also please take care we should use a tab instead of
8 spaces for the indentation of ChangeLog lines, though I guess
your mailer did it. Ok with that change. Thanks!
Regards,
kaz