This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix tree-ssa-coalesce ICE on ASM_EXPR (PR tree-optimization/31866)
- From: Andrew MacLeod <amacleod at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Diego Novillo <dnovillo at google dot com>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 20 Jun 2007 08:25:22 -0400
- Subject: Re: [PATCH] Fix tree-ssa-coalesce ICE on ASM_EXPR (PR tree-optimization/31866)
- References: <20070620113816.GI4033@devserv.devel.redhat.com>
On Wed, 2007-06-20 at 07:38 -0400, Jakub Jelinek wrote:
> Hi!
>
> create_outofssa_var_map ICEs on the attached testcase, because
> DECL_REGISTER VAR_DECL input isn't SSA_NAME (that's correct).
> create_outofssa_var_map needs SSA_NAME_VERSION of both the input
> and output to coalesce them, therefore trying to do anything to
> coalesce a VAR_DECL with SSA_NAME wouldn't fit well into the
> current coalescing framework.
>
I'm not sure why the && DECL_P was there... It clearly cannot work as
the code exists on that path...
> Ok for trunk?
yes, this is OK.
Note these wouldn't have coalesced anyway since the base variables are
different (r and s). Furthermore, the only place we ever coalesce
non-ssa-names with ssa_names is incoming arguments.
Andrew