This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch RFA] Fix sh64 build failure after dataflow merge


"Seongbae Park (박성배, 朴成培)" <seongbae.park@gmail.com> wrote:
>> @@ -1228,7 +1228,7 @@ move_btr_def (basic_block new_def_bb, in
>>         replacement_rtx = btr_rtx;
>>        else
>>         replacement_rtx = gen_rtx_REG (GET_MODE (user->use), btr);
>> -      validate_replace_rtx (user->insn, user->use, replacement_rtx);
>> +      validate_replace_rtx (user->use, replacement_rtx, user->insn);
>>        user->use = replacement_rtx;
>>      }
>>  }
> 
> I'm not sure I can approve this patch,
> but this is definitely ok from my point of view
>  (methinks this qualifies as obvious but others may beg to differ).

Thanks!  Your comment makes me believe that I do the right thing
this time.  I think your dataflow maintainership is ok to approve
this change because this is for a dataflow merge issue anyway, but
I'd like to wait for someone to confirm it or to approve the patch
directly.

Regards,
	kaz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]