This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tuples] Tuples accessors patch
- From: "Andrew Pinski" <pinskia at gmail dot com>
- To: "Christopher Matthews" <chrismatthews at google dot com>
- Cc: "Aldy Hernandez" <aldyh at redhat dot com>, Diego <dnovillo at google dot com>, "Ian Lance Taylor" <iant at google dot com>, gcc-patches at gcc dot gnu dot org
- Date: Sat, 16 Jun 2007 00:34:28 -0700
- Subject: Re: [tuples] Tuples accessors patch
- References: <5794c4c80706151821v76cd5a7dm4497da81ae05a58@mail.gmail.com>
On 6/15/07, Christopher Matthews <chrismatthews@google.com> wrote:
Some quick comments about your changelog.
2007-06-15 Chris Matthews <chrismatthews@google.com>
* gcc/Makefile.in (GTFILES): added gimeple-ir.h.
Capitalize A in Added as it begins a sentence.
This is going in gcc/ChangeLog.tuples, you don't need gcc/.
The rest of the changelog has this problem also.
+/* Construct a GS_NOP statement. */
+
+gimple
+gs_build_nop (void)
+{
+ gimple p;
+
+ p = ggc_alloc_cleared (sizeof (struct gimple_statement_base));
+ GS_CODE (p) = GS_NOP;
+
+ return p;
+}
+
Even though this is only partly unrelated to your patch. When do we
really need a GS_NOP statement? I know tree-ssa-phiopt uses NOP
statements on the trunk. That was because at the time I wrote that
part, I could not figure out a better way of inserting a statement at
the begining of a basic block when the bb was empty. I think that is
the only place which uses NOP statements. I really want to rewrite
phiopt using fold (or another folding function) which should simplify
all this code. Though I doubt I will be able to get to that for a
while.
Thanks,
Andrew Pinski