This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: gcov: new option to merge results



On Jun 12, 2007, at 4:18 PM, Nathan Sidwell wrote:


Tristan Gingold wrote:
Hi,
this is the updated version of the patch. No new option, results are merged as soon as there are multiple input files.

You've used two different approaches to scanning a files function list. Here you clear the list and then reattach it at the end:

[...]
but later on you have a case where you just remember the original list head and stop scanning when you reach that point. IMHO the latter approach is more readable.

Ok, I will change the former.


  Is there a reason the above loop cannot simply be:
	function_t *orig_functions = functions;
	...
	for (fn = functions; fn != orig_functions; fn->next)
	solve_flow_graph (fn)
?

Indeed, this will be clearer.


Thank you for your comments, I will make the changes.
Tristan.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]