This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, middle-end]: Optimize a/sqrt(b/c) into a*sqrt(c/b).


On 6/10/07, Uros Bizjak <ubizjak@gmail.com> wrote:
2007-06-11 Uros Bizjak <ubizjak@gmail.com>

        PR middle-end/32279
        * gcc.dg/builtins-11.c: Check folding of a/sqrt(b/c).

Please add a new testcase instead of modifying an old one. I think there are only a couple of reasons why you should ever be editing a testcase: 1) the testcase has invalid code in it (you either make it valid or add dg-error) 2) the testcase has undefined code in it (make it defined or the option to make work) 3) the IR changes to better optimize the code (this only happens with scan-* and it should be looked at closer than saying we need to change the scan-* when the test fails)

If people argree, I can write up something for
http://gcc.gnu.org/codingconventions.html which currently talks about
testcases already.

Thanks,
Andrew Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]