Re: [PATCH] Improve debug info for Ada (2/4)

[Geoffrey Keating <geoffk at apple dot com>]

Hi Eric,

Your patch

------------------------------------------------------------------------
r121861 | ebotcazou | 2007-02-12 13:01:33 -0800 (Mon, 12 Feb 2007) |  
5 lines

        * tree.h (DECL_IGNORED_P): Document further effect for  
FUNCTION_DECL.
        * cgraphunit.c (cgraph_expand_function): If DECL_IGNORED_P  
is set on
        the function, temporarily point the debug interface to the  
null one.


breaks bootstrap on i386-darwin9, because the Darwin backend is not  
expecting the debug information type to suddenly change from DWARF to  
nothing in the middle of a compilation.  See the definition of  
DBX_REGISTER_NUMBER in darwin.h.

All the other implementation of DECL_IGNORED_P is done by the  
debugging output backends and it's done differently for each  
backend.  In particular the DWARF output code doesn't actually  
suppress any debug information, it just marks it as  
DW_AT_artificial.  We had extensive discussion about this on the list  
and agreed this was the right thing to do.

From your discussion at <http://gcc.gnu.org/ml/gcc-patches/2007-02/ 
msg01079.html> I believe that this should work.  The debugger will  
see the DW_AT_artificial and won't see the function as a breakpoint  
target.  If it doesn't work that's a debugger problem not a compiler  
one.

So, I propose reverting this patch.  What do you think?

Attachment: smime.p7s
Description: S/MIME cryptographic signature