This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][RFC] Minuscule patch to remove apparently accidental break from switch


Simon Baldwin wrote:
Andrew Pinski wrote:

On 6/5/07, Simon Baldwin <simonb@google.com> wrote:

An apparently misplaced break statement within simplify_binary_operation_1()
causes calls to simplify_associative_operation() for xor operations to
potentially be missed.


This patch removes the break, enabling simplify_associative_operation().

Regression tested on i386 against the full g++ testsuite.


Can you run against the whole testsuite instead of just the g++?  This
patch really needs a full bootstrap with all languages enabled as it
changes the middle-end.


Thanks for the note. That's actually my typo in the patch description; I've actually run both C and C++ testsuites. That is, all tests enabled by "configure --enable-languages=c,c++".


Will those cover it, or should I plough through Fortran, ADA, and so on as well?

Just remove the --enable-languages and test all default languages.


David Daney


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]