This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR 32146 (Bad matrix layout transformations)

From: Diego Novillo <dnovillo at google dot com>
To: Razya Ladelsky <RAZYA at il dot ibm dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Thu, 31 May 2007 08:54:29 -0400
Subject: Re: [PATCH] PR 32146 (Bad matrix layout transformations)
References: <OFB2A871D4.BE4B0758-ONC22572EC.00429C51-C22572EC.00450E37@il.ibm.com>

On 5/31/07 8:37 AM, Razya Ladelsky wrote:

> 2007-05-31  Razya Ladelsky  <razya@il.ibm.com>
> 
>         * matrix-reorg.c (transform_access_sites): Fix computation.
>            (transform_allocation_sites): Same.
>         *  testsuite/gcc.dg/matrix/matrix-6.c: Remove conversion.

OK with a couple of nits

> ! 	      if (x - y == 0)

This is an odd way to ask 'x == y'.  Any specific reason?

> ! 		dim_size = mi->dimension_size_orig[id];
> ! 	      else
> ! 		{

No braces needed here.

Follow-Ups:
- Re: [PATCH] PR 32146 (Bad matrix layout transformations)
  - From: Razya Ladelsky

References:
- [PATCH] PR 32146 (Bad matrix layout transformations)
  - From: Razya Ladelsky

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]