This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, i386]: Change options handling for i386 target


Andreas Tobler wrote:

The patch was regression tested on i686-pc-linux-gnu for all default
languages. I plan to re-run the tests on x86_64 in a couple of hours.
However, I would like someone to test this change on Darwin, due to
small darwin.h change - do we really need to redefine TARGET_64BIT
define to the same default value... ?

Can't say if we need the TARGET_64BIT redefine, but it seems to me that we need to undef the TARGET_SUBTARGET_DEFAULT before redefining it ?

Uh, thanks for this report. This is fixed by the patch below.


2007-05-30 Uros Bizjak <ubizjak@gmail.com>

* config/i386/darwin.h (TARGET_SUBTARGET_DEFAULT): Undef before define.

Uros.

Index: config/i386/darwin.h
===================================================================
--- config/i386/darwin.h        (revision 125197)
+++ config/i386/darwin.h        (working copy)
@@ -128,6 +128,7 @@
/* By default, target has a 80387, uses IEEE compatible arithmetic,
   and returns float values in the 387.  */

+#undef TARGET_SUBTARGET_DEFAULT
#define TARGET_SUBTARGET_DEFAULT (MASK_80387 | MASK_IEEE_FP | MASK_FLOAT_RETURNS | MASK_128BIT_LONG_DOUBLE)


/* For now, disable dynamic-no-pic. We'll need to go through i386.c


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]