Re: [PATCH] fix compare_tests

[Mike Stump <mrs at apple dot com>]

On May 29, 2007, at 4:14 PM, Dirk Mueller wrote:
> at least on my test system, XFAIL'ed testcases also seem to PASS

?

It's been working reliably for a very long time, not sure what you're  
referring to.  Could you give me an example (input x2 and the  
output)?  A single line for each input should be sufficient.

> --- compare_tests	(revision 125134)
> +++ compare_tests	(working copy)
> @@ -10,6 +10,7 @@
>
> # Written by Mike Stump <mrs@cygnus.com>
>
> +export LC_ALL=C

This part is Ok.


> -grep '^FAIL:' "$now_s" | sed 's/^[^:]*:[ 	]//' >$tmp1
> +grep '^FAIL' "$now_s" | sed 's/^[^:]*:[ 	]//' >$tmp1

No...  Sounds like a consistency thang...

> grep '^PASS' "$before_s" | sed 's/^[^:]*:[ 	]//' | comm -12 $tmp1 - > 
> $tmp2

This line should have a : added instead, if you want consistency.  The  
form is PASS:.* or FAIL:.*, not PASS.*.