This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Add SSE4.2 support
On Wed, May 23, 2007 at 04:32:02PM +0200, Uros Bizjak wrote:
> On 5/23/07, H. J. Lu <hjl@lucon.org> wrote:
>
> >> The "hardest" part is to review uses of target_flags and
> >> target_flags_explicit throughout the i386 directory and change them to
> >> operate on target_mmxsse_flags variable and (new)
> >> target_mmxsse_flags_explicit global variable (defined in i386.h?). As
> >
> >I am not sure if it will work since target_flags_explicit and
> >target_flags are handled in opts.c. I am thinking to add support
> >for
>
> I have solved this by adding separate variable
> target_mmxsse_flags_explicit, local to i386.c scope. Attached
> proto-patch implements this suggestion (it bootstraps & regression
> tests OK, but is quite big due to def_builtin() change. A flags field
> was reused to separate TARGET_64BIT (referenced to target_flags) from
> TARGET_SSE (referenced to target_ssemmx_flags).
I would prefer target_isa_flags/target_isa_flags_explicit and
add a new file config/i386/isa.opt for ISA optoons to make it clear
that all options in config/i386/isa.opt will be in a different
target flag.
>
> >
> >msse4
> >Target Report Mask(SSE4) Var(target_mmxsse_flags) Explicit
>
> Hm, I can't find "Explicit" option described anywhere.
I meant to add this feature.
>
> For clarity, all uses of TARGET_SSExxx should be turned into
> OPTION_SSExxx. Does somebody already have a script that would process
> all sources in the directory and make this change?
>
Use OPTION_SSExxx will make it harder to compare gcc 4.3 with
gcc 4.2.
H.J.