This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, libgfortran] String spring cleanup (or, spring string cleanup)
- From: FX Coudert <fxcoudert at gmail dot com>
- To: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 23 May 2007 10:34:01 +0200
- Subject: Re: [Patch, libgfortran] String spring cleanup (or, spring string cleanup)
- References: <46508A46.3030403@gmail.com>
:REVIEWMAIL:
2007-05-20 Janne Blomqvist <jb@gcc.gnu.org>
* runtime/string.c (compare0): Use gfc_charlen_type instead of int.
(fstrlen): Likewise.
(find_option): Likewise.
(fstrcpy): Use gfc_charlen_type instead of int, return length.
(cf_strcpy): Likewise.
* libgfortran.h: Change string prototypes to use gfc_charlen_type.
* io/open.c (new_unit): Use snprintf if available.
* io/list_read.c (nml_touch_nodes): Use memcpy instead of strcpy/
strcat.
(nml_read_obj): Likewise.
* io/transfer.c (st_set_nml_var): Likewise.
* io/write.c (output_float): Use snprintf if available.
(nml_write_obj) Use memcpy instead of strcpy/strcat.
Looks sane, and I didn't spot any typo or other such problem. This is
OK, provided that you have built libgfortran and checked that no
warning is introduced by this change. (Also, if you have x86_64
available somewhere, this might be interesting to try before
committing because charlen is then 32 bits wide while size_t is 64
bits wide, I think.)
Thanks,
FX