This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: PR middle-end/31796 use MPFR to evaluate remquo/remainder/drem at compile-time
On Thu, 17 May 2007, Richard Guenther wrote:
> On 5/5/07, Kaveh R. GHAZI <ghazi@caip.rutgers.edu> wrote:
> > This patch address PR middle-end/31796. It uses MPFR to evaluate remquo,
> > remainder and drem at compile-time when they are supplied with constant
> > arguments.
> >
> > This patch relies on the follow two previous (and as yet unreviewed)
> > patches to apply cleanly:
> >
> > http://gcc.gnu.org/ml/gcc-patches/2007-04/msg01624.html
> > http://gcc.gnu.org/ml/gcc-patches/2007-04/msg01663.html
> >
> > Tested on sparc-sun-solaris2.10, no regressions and the new tests all
> > pass.
> >
> > Okay for mainline?
>
> This is ok if you XFAIL the testcases that require new mpfr. Also
> please consider adding new testcase files for those that need XFAILing
> (I suppose builtin-math-4.c is from some other patch taht did not went
> in yet).
> Richard.
Yes, all the GCC+mpfr-2.3.0 "affirmative" tests (i.e. they should
transform) are in their own file builtin-math-4.c which is currently
xfailed.
All MPFR "negative" tests (i.e. math functions should not transform
because e.g. their inputs are invalid) are in builtin-math-2.c. This test
should not need to be xfailed because when using older MPFR versions, none
of the relevant 2.3.0 functions transform anyway. So it passes regardless
of the MPFR version used and xfailing it would yield testsuite problems.
I just tested it again using gcc trunk + mpfr-2.2.1 and it "passed".
Thanks very much for all the reviews today! :-) I've installed all but the
reentrant lgamma one which you requested a change to. I'll investigate
that ASAP.
Thanks,
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu