This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tuples] tree-pretty-print changes
- From: Aldy Hernandez <aldyh at redhat dot com>
- To: Gabriel Dos Reis <gdr at cs dot tamu dot edu>
- Cc: dnovillo at acm dot org, rth at redhat dot com, amacleod at redhat dot com, gcc-patches at gcc dot gnu dot org
- Date: Fri, 4 May 2007 09:13:10 -0400
- Subject: Re: [tuples] tree-pretty-print changes
- References: <20070504122929.GA15701@redhat.com> <87ejlw9204.fsf@soliton.cs.tamu.edu>
On Fri, May 04, 2007 at 08:01:15AM -0500, Gabriel Dos Reis wrote:
> Aldy Hernandez <aldyh@redhat.com> writes:
>
> | This is a subset from yesterday's patch. I'm trying to offload the non
> | controversial parts of the changes to the branch.
> |
> | Committed to branch.
> |
> | * tree-pretty-print.c (do_gs_niy): New.
> | (debug_gimple_stmt): New.
> | (debug_gimple_seq): New.
> | (print_gimple_stmt): New.
> | (dump_gimple_stmt): New.
> | * diagnostic.h: Add prototypes for dump_gimple_stmt,
> | print_gimple_stmt, debug_gimple_stmt, debug_gimple_seq.
>
> I see there are other "print" routines declared in diagnostic.h, but
> they have nothing to do with diagnostics. They most naturally belong
> to some tree-pretty-print.h.
Yeah I saw that. But do we really want to add yet another header file for
just a handful of prototypes? It seems almost every place we include
diagnostic.h we'd have to include tree-pretty-print.h too, cause there's
an awful lot of uses of print_generic_* and friends.
Either way I'm fine with it, I just didn't want to disturb things too much.