Re: [patch 2/2] PR27313 Transform conditional stores

[Tehila Meyzels <TEHILA at il dot ibm dot com>]

Michael Matz <matz@suse.de> wrote on 30/04/2007 16:12:01:

> Hi,
>
> On Sun, 29 Apr 2007, Tehila Meyzels wrote:
>
> > I've tried to apply your patches on mainline (revision: r124154), on
> > ppc64-redhat-linux.
> > I've gotten the following error:
> >
> > ppc64-redhat-linux-gcc -c   -g -fkeep-inline-functions -DIN_GCC   -W
-Wall
> > -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes
> > -Wold-style-definition -Wmissing-format-attribute -fno-common
> > -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/.
> > -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include
> > -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd
> > -I../libdecnumber    ../../gcc/gcc/tree-ssa-phiopt.c -o
tree-ssa-phiopt.o
> > ../../gcc/gcc/tree-ssa-phiopt.c: In function âconditional_replacementâ:
> > ../../gcc/gcc/tree-ssa-phiopt.c:491: error: invalid storage class for
> > function âcond_store_replacementâ
> > ../../gcc/gcc/tree-ssa-phiopt.c:491: warning: no previous prototype for
> > âcond_store_replacementâ
> > make[3]: *** [tree-ssa-phiopt.o] Error 1
> >
> > Have I done something wrong???
>
> You must have gotten some merge conflicts, or the like.  There is no call

> to cond_store_replacement() inside conditional_replacement().  It was
> added to tree_ssa_phiopt_worker().  Furthermore the patch also adds a
> prototype for that function at file global level.
>
> But that patch is bound to die in that form anyway.  The notrap property
> can't be easily expressed in our infrastructure, so I've integrated it
> into the transformation itself.  A pity.  But try the attached patch
> instead.
>
>

Thanks, Michael. it seems working (with the newer patch).

Tehila.


> Ciao,
> Michael.[attachment "all-cselim.diff" deleted by Tehila
Meyzels/Haifa/IBM]