This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR 29609, being able to set a breakpoint on goto/continue/break


On 4/30/07, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
On 4/30/07, Daniel Jacobowitz <drow@false.org> wrote:
> Stop me if I misunderstand.  But wasn't this bug originally about -O0?
> Assuming so, Tristan is correct and his fix of moving the goto into
> its own basic block is probably necessary in addition to fixing up the
> locus.

It really is not necessary.  You can have a location for the
if-statement and another location for the goto-statement, not even if
the goto_expr is not there, and not even at -O0.

Hm no. Actually you're right. For the explicit goto we do need the separate basic block, because, as you said, we always end up stepping onto the break if it's treated as an implicit goto. Hmm... But that still feels wrong somehow. I need to think this over some more... Maybe we can still fix this in cfgexpand instead of adding extra basic blocks.

Gr.
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]