Re: [RFA:] Fix for Your libstdc++ testsuite changes causes regressions

[Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>]

> Date: Sun, 29 Apr 2007 12:08:03 +0100
> From: Nathan Sidwell <nathan@codesourcery.com>

> Hans-Peter Nilsson wrote:
> > :ADDPATCH libstdc++ testsuite:
> 
> > How did you perform that non-combined (newlib+gcc) build?
> 
> I've not got to trying a combined build (That was going to be this evening's 
> entertainment :).   for the non-combined build I had separate binutils, gcc & 
> newlib sources.  From memory the build was something like
> *) config, build & install binutils
> *) config gcc with --enable-languages=c, --with-newlib --disable-libssp 
> --disable-libgomp --disable-a-couple-of-other-things
> *) build & install that
> *) config, build & install newlib with the just build gcc
> *) go back to gcc and config with --enable-languages=c,c++ and the other options 
> I mentioned
> *) build that gcc, and now test it.
> *) config with --disable-a-couple-of-other-things

That's what I feared.  For the record IMHO I wouldn't do this;
it's unnecessary extra work (build time for the extra gcc round
anyway, if it's all automated), to avoid combining
newlib+binutils+gcc+sim sources.  I've mentioned
simtest-howto.html already.

> ug, that original regexp is just such a hack.  Your patch looks ok to me.  I'm 
> not an expert on tcl regexps, so don't know about the universality of the \s 
> piece.  But I guess [ \t] would also work there.

I guess I should be clearer: I did check with the Tcl-8.4
documentation at tcl.tk.  The FC 2 from three years ago where I
tested has tcl-8.4.5 (sorry not four years, but I see tcl-8.4.0
is from 2002 anyway).  I'm slightly happier with \s than the
"manual" tab-space expansion.  Whatever the libstdc++
maintainers prefer, of course.

brgds, H-P