This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [dataflow] PATCH COMMITTED to fix storage and performance issues


On 4/24/07, Kenneth Zadeck <zadeck@naturalbridge.com> wrote:
I wrote this code after i noticed regressions when i ran the new dse on
the mainline right in front of flow based dse.  It turns out that flow
secretly did this.

Yeah, and that by itself is enough to justify adding it to your dse pass too.



I had asked you and bonzini if there was already code to do this.

I must have missed this question, or I have misinterpreted it. Sorry if this comes as a surprise for you.


and I
would have enabled/fixed it rather than writting this myself has you
offered this.  Though i must admit that such gcse code would find
different things than this code does because that code would find a
weaker set of address globally.

Right. I think your pass will still be useful. If the big win comes mostly from running after RTL loop optimizations, then doing it in GCSE is simply too early.

Gr.
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]