This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fix long-term -fgcse-sm bug


On Apr 21, 2007, "Steven Bosscher" <stevenb.gcc@gmail.com> wrote:

> On 4/21/07, Alexandre Oliva <aoliva@redhat.com> wrote:
>> On Apr 20, 2007, "Steven Bosscher" <stevenb.gcc@gmail.com> wrote:
>> 
>> > On 4/20/07, Alexandre Oliva <aoliva@redhat.com> wrote:
>> >> > But unfortunately, as rth already pointed out the loop you crafted
>> >> > took a bit of effort to dig.
>> >>
>> >> Would it make it any better if I factored it into a macro?
>> 
>> > Sorry...  Might look better if you make it an iterator like we've done
>> > for bitmaps and cfg edges.
>> 
>> Err...  iterator as in typedef unsigned some_iterator_type, and use
>> that for the index?

> No, something like the iterators for CFG edges.  See edge_iterator and
> FOR_EACH_EDGE.

So how is this different from what I proposed, except for the fact
that for this case we don't really need a separate type?

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
FSF Latin America Board Member         http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]