This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran] Point to -frange-check in the error message (Re: data type problems)
- From: "François-Xavier Coudert" <fxcoudert at gmail dot com>
- To: "Tobias Burnus" <burnus at net-b dot de>
- Cc: "Brooks Moses" <bmoses at stanford dot edu>, gcc-patches <gcc-patches at gcc dot gnu dot org>, "Steve Kargl" <sgk at troutmask dot apl dot washington dot edu>, fortran at gcc dot gnu dot org
- Date: Fri, 20 Apr 2007 23:50:44 +0200
- Subject: Re: [patch, fortran] Point to -frange-check in the error message (Re: data type problems)
- References: <20070411224140.GB3170@oldben.llnl.gov> <20070411225430.GA15546@troutmask.apl.washington.edu> <461DB031.1060702@codesourcery.com> <4.3.1.2.20070411235654.02caffa0@cits1.stanford.edu> <461DF360.9030801@net-b.de>
Hi Tobias,
Noone commented your patch:
2007-04-12 Tobias Burnus <burnus@net-b.de>
* primary.c (match_integer_constant): Mention -fno-range-check
in the error message.
I think it's a good idea, but I'd change the message from:
+ gfc_error ("Integer too big for its kind at %C. Use -fno-range-check "
+ "to disable this check.");
to something that is not so directive (after all, it's only a
workaround, and probably a bad thing to do if you can modify the
code). Perhaps "This check can be disabled with option
-fno-range-check"?
Let's say we give 48 hours to people who want to object or help design
the wording of the message, and then it's OK to commit. If you have
another idea for the message than the one I gave, please go for it!
FX