This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Extend MVE patterns
- From: Revital1 Eres <ERES at il dot ibm dot com>
- To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
- Cc: gcc-patches at gcc dot gnu dot org, Steven Bosscher <stevenb dot gcc at gmail dot com>
- Date: Mon, 16 Apr 2007 22:03:04 +0300
- Subject: Re: [PATCH] Extend MVE patterns
Thanks,
I'll commit the patch with those changes.
Revital
Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz> wrote on 16/04/2007
19:31:35:
> Hello,
>
> > - if (!rtx_equal_p (dest, op1))
> > + if (!rtx_equal_p (dest, op1) && !rtx_equal_p (dest, op2))
> > return NULL;
>
> if (rtx_equal_p (dest, op1))
> accum_pos = 0;
> else if (rtx_equal_p (dest, op2))
> accum_pos = 1;
> else
> return NULL;
>
> > +
> > + /* The method of expansion that we are using; which includes
> > + the initialization of the expansions with zero and the summation
of
> > + the expansions at the end of the computation will yield wrong
results
> > + for (x = something - x) thus avoid using it in that case. */
> > + if (rtx_equal_p (dest, op2)
>
> if (accum_pos == 1
>
> > + && GET_CODE (src) == MINUS)
> > + return NULL;
> > +
> > + /* Expand also x = something + x. */
>
> remove this comment, it does not make much sense unless one
> investigates history of the code.
>
> > + accum_pos = (rtx_equal_p (dest, op1))? 0: 1;
>
> delete
>
> > + something = (accum_pos == 0)? op2: op1;
>
> missing space before :
>
> OK with these changes.
>
> Zdenek