This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] pass @-files to collect2 and beyond


On Sun, Apr 15, 2007 at 01:26:47PM -0700, Mark Mitchell wrote:
> However, the problem here is that people tend to use response files when
> command lines are too long for the system.  So, not using them for
> subprocesses will often result in a silent error; the OS will truncate
> the command-line and something odd will happen.
> 
> Nathan, if I understand correctly, the change to gcc.c is only for
> invoking ld?  That makes sense, as the command-line for "as" is unlikely
> to be very long.

That's correct.  Even if invoked with an @-file, gcc passes assembly
files one at a time to "as".

> In that case, I think we need to arrange as follows:
...
> As a minor nit about the patch:
...
> Also, the duplicated code between collect2.c and gcc.c is troubling.  I
> think that we should provide another function in libiberty/argv.c, like:
> 
> int
> writeargv(const char **argv, FILE *file)

Duly noted, will address these in the revised patch.

Thanks,
-Nathan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]