This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Final(?) patch to update libtool in GCC and src trees

From: Andreas Schwab <schwab at suse dot de>
To: bonzini at gnu dot org
Cc: Dave Korn <dave dot korn at artimi dot com>, 'Steve Ellcey' <sje at cup dot hp dot com>, binutils at sourceware dot org, gcc-patches at gcc dot gnu dot org, gdb-patches at gcc dot gnu dot org, newlib at sourceware dot org, Ralf dot Wildenhues at gmx dot de, aoliva at redhat dot com, libtool at cwilson dot fastmail dot fm
Date: Wed, 11 Apr 2007 10:47:34 +0200
Subject: Re: Final(?) patch to update libtool in GCC and src trees
References: <006501c77bab$1753a410$2e08a8c0@CAM.ARTIMI.COM> <200704102006.NAA21177@hpsje.cup.hp.com> <008301c77bd6$7fa44bc0$2e08a8c0@CAM.ARTIMI.COM> <461C8FE6.9010800@lu.unisi.ch>

Paolo Bonzini <paolo.bonzini@lu.unisi.ch> writes:

> Inside those two lines we have
>
> if test "${use_libtool}" = "yes"; then
> AC_LIBTOOL_WIN32_DLL
> AM_PROG_LIBTOOL
> AC_PROG_AWK
> fi
>
> I would rewrite them at the very least as
>
> AC_PROG_AWK
> AC_PROG_CXX
>
> if test "${use_libtool}" = "yes"; then
> AC_LIBTOOL_WIN32_DLL
> AM_PROG_LIBTOOL
> fi

I think that should use AS_IF instead.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Follow-Ups:
- Re: Final(?) patch to update libtool in GCC and src trees
  - From: Paolo Bonzini

References:
- RE: Final(?) patch to update libtool in GCC and src trees
  - From: Dave Korn
- Re: Final(?) patch to update libtool in GCC and src trees
  - From: Steve Ellcey
- RE: Final(?) patch to update libtool in GCC and src trees
  - From: Dave Korn
- Re: Final(?) patch to update libtool in GCC and src trees
  - From: Paolo Bonzini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]