This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] the comparison rtx_code for __builtin_ia32_cmpordss function

From: Uros Bizjak <ubizjak at gmail dot com>
To: GCC Patches <gcc-patches at gcc dot gnu dot org>
Cc: Hui-May Chang <hm dot chang at apple dot com>
Date: Sun, 08 Apr 2007 11:51:53 +0200
Subject: Re: [patch] the comparison rtx_code for __builtin_ia32_cmpordss function

Hello!

gcc/ChangeLog:
        * config/i386/i386.c (bdesc_2arg[]) : The comparison rtx_code
        for __builtin_ia32_cmpordss should ORDERED instead of
        UNORDERED.

gcc/testsuite/ChangeLog:
        gcc.target/i386/sse-cmpordss.c: New.

Nice catch!

Patch is OK for mainline, but please change the ChangeLog intro to something like: * config/i386/i386.c (bdesc_comi)[__builtin_ia32_cmpordss]: Use ORDERED instead of UNORDERED.

The patch is also safe enough for 4.1 and 4.2 branches. However, let's wait a couple of days for possible comments from release manager.

Thanks,
Uros.

Follow-Ups:
- Re: [patch] the comparison rtx_code for __builtin_ia32_cmpordss function
  - From: Mike Stump

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]