This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Remove staticp langhook


As this is causing failures in C for some people, i'm reverting it.
It looks like we try to use it for determining whether initializer
constants are valid in C, and hand it compound literals.

Shame, since all we do in that case is check TREE_STATIC on them, but
I really don't want to go mucking through to see what is up.

For purposes of the middle end, we can just switch the langhook to the
default after the frontends are done processing, which is all I really
care about.

On 4/5/07, Daniel Berlin <dberlin@dberlin.org> wrote:
This langhook is a remnant from a time when expand had to handle all
the frontend specific trees.
This is no longer the case, and as such, all the implementations of
this are dead code.

I have added asserts in place of the langhook use on the off chance
someone out-of-tree is trying to still throw lang-specific trees at
expand.

Bootstrapped and regtested on i686-pc-linux-gnu and i686-darwin.
Okay for mainline?

In /
2007-04-05  Daniel Berlin  <dberlin@dberlin.org>

        * tree.c (staticp): No longer use staticp langhook.
        * langhooks.c (lhd_staticp): Removed.
        * langhooks.h (struct lang_hooks): Remove staticp.
        * c-common.c (c_staticp): Remove.
        * c-common.h (c_staticp): Ditto.
        * langhooks-defs.h (lhd_staticp): Ditto.
        (LHD_HOOKS_STATICP): Ditto

In cp/
2007-04-05  Daniel Berlin  <dberlin@dberlin.org>

        * cp-objcp-common.c (cxx_staticp): Remove.
        * cp-objcp-common.h (LANG_HOOKS_STATICP): Remove.
        * cp-tree.h (cxx_staticp):




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]