This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: patch: sh wrong scheduling description
- From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- To: christian dot bruel at st dot com
- Cc: gcc-patches at gcc dot gnu dot org, aoliva at redhat dot com
- Date: Wed, 28 Mar 2007 19:44:52 +0900 (JST)
- Subject: Re: patch: sh wrong scheduling description
- References: <460A2168.2040102@st.com>
Hi Christian,
Christian BRUEL <christian.bruel@st.com> wrote:
> the attached patch fixes a scheduling performance issue with nofpu sh
> models.
>
> Memory accesses was issuing a d_lock reservation instead of an sh4_load
> reservation. (Similarly the type for the mac constraints looks mixed up).
The patch looks fine, but please comment on how it has been tested.
Is it regtested on sh-elf?
> * config/sh/sh.md (movsi_i): Fix type attribute for r,m and x,<
> constraints.
"r,m and x,<" part may be a little confusing because they follow
source-destination order which is reverse to the operands order.
Simply "Fix type attribute." would be enough.
Regards,
kaz