This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: output # <srcline> between #APP and #NO_APP, for asm statements
On Mar 16, 2007, Andreas Schwab <schwab@suse.de> wrote:
> Alexandre Oliva <aoliva@redhat.com> writes:
>> - if test $gcc_cv_gas_vers -ge `expr \( \( elf,2,16,91 \* 1000 \) + gcc_cv_as_line_zero=yes \) \* 1000 + `
>> + if test $gcc_cv_gas_vers -ge `expr \( \( 2,16,91 \* 1000 \) + gcc_cv_as_line_zero=yes \) \* 1000 + `
> How is this suposed to work?
Easy. Someone actually tests the feature in a unified tree and finds
it's broken, or some attentive eyes catch it and report it. Then, the
embarrassed developer who should have noticed it himself installs a
patch after testing it on a unified tree, where it should have been
tested in the first place, and, voila, it works ;-)
:-/
Here's what I'm checking in, thanks,
Index: gcc/ChangeLog
from Alexandre Oliva <aoliva@redhat.com>
* configure.ac: Remove excess quoting from asm line 0 test.
* configure: Rebuilt.
Index: trunk/gcc/configure
===================================================================
--- trunk.orig/gcc/configure 2007-03-16 02:49:05.000000000 -0300
+++ trunk/gcc/configure 2007-03-16 20:06:37.000000000 -0300
@@ -16045,8 +16045,8 @@ if test "${gcc_cv_as_line_zero+set}" = s
else
gcc_cv_as_line_zero=no
if test $in_tree_gas = yes; then
- if test $gcc_cv_gas_vers -ge `expr \( \( 2,16,91 \* 1000 \) + gcc_cv_as_line_zero=yes \) \* 1000 + `
- then :
+ if test $gcc_cv_gas_vers -ge `expr \( \( 2 \* 1000 \) + 16 \) \* 1000 + 91`
+ then gcc_cv_as_line_zero=yes
fi
elif test "x$gcc_cv_as" != x; then
{ echo '# 1 "test.s" 1'; echo '# 0 "" 2'; } > conftest.s
Index: trunk/gcc/configure.ac
===================================================================
--- trunk.orig/gcc/configure.ac 2007-03-16 02:49:05.000000000 -0300
+++ trunk/gcc/configure.ac 2007-03-16 19:56:41.000000000 -0300
@@ -3079,7 +3079,7 @@ AC_CACHE_CHECK([assembler for tolerance
[gcc_cv_as_line_zero],
[gcc_cv_as_line_zero=no
if test $in_tree_gas = yes; then
- gcc_GAS_VERSION_GTE_IFELSE([2,16,91], [gcc_cv_as_line_zero=yes])
+ gcc_GAS_VERSION_GTE_IFELSE(2, 16, 91, [gcc_cv_as_line_zero=yes])
elif test "x$gcc_cv_as" != x; then
{ echo '# 1 "test.s" 1'; echo '# 0 "" 2'; } > conftest.s
if AC_TRY_COMMAND([$gcc_cv_as -o conftest.o conftest.s >&AS_MESSAGE_LOG_FD 2>conftest.out]) &&
--
Alexandre Oliva http://www.lsd.ic.unicamp.br/~oliva/
FSF Latin America Board Member http://www.fsfla.org/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}