Re: Add -iframework

[Mike Stump <mrs at apple dot com>]

On Oct 8, 2006, at 9:43 PM, Mark Mitchell wrote:
> Mike Stump wrote:
>
> > 	* c-opts.c (c_common_handle_option): Handle language specific
> > 	target options.
> > 	* opts.c (handle_option): Verify language for target options, if
> > 	any are given.
> > 	* opth-gen.awk: Add CL_LANG_ALL.
> > 	* config/darwin.opt (iframework): Add.
> > 	* config/darwin.h (TARGET_HANDLE_C_OPTION): Add.
> > 	* config/darwin-c.c (add_system_framework_path): Export.
> > 	(darwin_handle_c_option): Add.
> > 	* config/darwin-protos.h (darwin_asm_output_anchor): Add.
> > 	* doc/invoke.texi (Darwin Options): Add -iframework.
> > 	* doc/tm.texi (TARGET_HANDLE_C_OPTION): Add.
>
> TARGET_HANDLE_C_OPTION should be a target hook, not a new target  
> macro; we're trying to eliminate target macros.
>
> Fundamentally, though, this version still doesn't live only with  
> Darwin configuration files, and -iframework is clearly a new  
> feature; please hold on to it for 4.3 stage 1.

Well, just getting back to this one...  All this to add two lines of  
glue code to the compiler.  :-(

The benefit of this incantation is that we don't have to modify every  
target gcc supports.

Almost obvious, but anytime you  need 272 lines of diffs for a 2 line  
patch, one does have to wonder if the cure isn't worse than the disease.

Ok?

Attachment: framework-1d.diffs.txt
Description: Text document