This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory

From: Mark Mitchell <mark at codesourcery dot com>
To: Michael Matz <matz at suse dot de>
Cc: Daniel Jacobowitz <drow at false dot org>, Richard Guenther <rguenther at suse dot de>, Gabriel Dos Reis <gdr at cs dot tamu dot edu>, gcc-patches at gcc dot gnu dot org
Date: Wed, 21 Feb 2007 11:23:32 -0800
Subject: Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
References: <20061211155733.GA2660@nevyn.them.org> <Pine.LNX.4.64.0612111658590.29962@wotan.suse.de> <20061211174548.GA7094@nevyn.them.org> <Pine.LNX.4.64.0612121519200.29962@wotan.suse.de> <20061212150652.GA18750@nevyn.them.org> <Pine.LNX.4.64.0612121723070.29962@wotan.suse.de> <457EF130.5040902@codesourcery.com> <Pine.LNX.4.64.0612131535100.29962@wotan.suse.de> <4580405A.4000109@codesourcery.com> <Pine.LNX.4.64.0702201500170.25448@wotan.suse.de> <20070220143731.GA8544@caradoc.them.org> <Pine.LNX.4.64.0702201602540.25448@wotan.suse.de> <45DB898E.8080401@codesourcery.com> <Pine.LNX.4.64.0702211628450.25448@wotan.suse.de>

Michael Matz wrote:

>> I spotted the same issue as Daniel.  I think that you do need to fix
>> this, buy threading a flag down through the diagnostic routines to cause
>> it to omit the qualifier on the (outermost) declarator.
> 
> Like the patch below.  It introduces TFF_NO_OUTER_SCOPE as formatting 
> flag, and uses it in the new cxx_dwarf_name langhook.

Please spell that as TFF_UNQUALIFIED_NAME, and document as "do not print
the qualifying scope of the top-level entity".

Since Daniel has signed off on the GDB impact, this patch is OK if it
passes the testsuites.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

Follow-Ups:
- Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
  - From: Michael Matz

References:
- Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
  - From: Michael Matz
- Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
  - From: Daniel Jacobowitz
- Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
  - From: Michael Matz
- Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
  - From: Mark Mitchell
- Re: [PATCH][C++] Fix PR29433, make C++ use a lot less time/memory
  - From: Michael Matz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]