This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [try2] PR28943 Unusable error message when using a conditional-expression with multiple type arguments
- From: Gabriel Dos Reis <gdr at cs dot tamu dot edu>
- To: Manuel López-Ibáñez <lopezibanez at gmail dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: 13 Feb 2007 17:50:19 -0600
- Subject: Re: [try2] PR28943 Unusable error message when using a conditional-expression with multiple type arguments
- References: <6c33472e0701310142i7cd71295r3f83f4169c7b9ed0@mail.gmail.com> <874pq71ozz.fsf@soliton.cs.tamu.edu> <6c33472e0702131502v6d722743k3072c981899e75b2@mail.gmail.com>
"Manuel López-Ibáñez" <lopezibanez@gmail.com> writes:
| On 31 Jan 2007 04:15:12 -0600, Gabriel Dos Reis <gdr@cs.tamu.edu> wrote:
| > "Manuel López-Ibáñez" <lopezibanez@gmail.com> writes:
| >
| > I would prefer the "improved" diagnostic to say something like
| >
| > third operand to the conditional operator is of type 'void', but
| > the second operand is neither a throw-expression nor of type 'void'
| >
| > and swap second/third the other around to cover the symmetric case.
| >
|
| Here is the improved patch. Bootstrapped and regression tested. I hope
| this is what you wanted.
Please split the long lines into something much shorter, taking
advantage of automatic string concatenaion -- see the coding standard.
The testcase is more verbose than it needs to be.
OK with those changes.
-- Gaby