This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [rs6000,patch] Fix ppc-specific problem with functions returning logical(8) value
- From: David Edelsohn <dje at watson dot ibm dot com>
- To: FX Coudert <fxcoudert at gmail dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>, geoffk at geoffk dot org, Andrew Pinski <pinskia at gmail dot com>, Dominique Dhumieres <dominiq at lps dot ens dot fr>
- Date: Mon, 12 Feb 2007 11:23:36 -0500
- Subject: Re: [rs6000,patch] Fix ppc-specific problem with functions returning logical(8) value
- References: <63B43377-5735-40B4-BB0D-1C3E22877EF7@gmail.com>
Wouldn't it be cleaner and clearer to write:
mode = TYPE_MODE (valtype);
if ((INTEGRAL_TYPE_P (valtype)
&& GET_MODE_BITSIZE (mode) < BITS_PER_WORD)
|| POINTER_TYPE_P (valtype))
mode = TARGET_32BIT ? SImode : DImode;
In general, the patch is okay on mainline and 4.2. Please do not include
the patch in 4.1.2.
Thanks, David