This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran] Use -huge()-1 as most negative integer for maxval/maxloc (PR30512)


On Sat, Feb 03, 2007 at 10:45:56AM +0100, Tobias Burnus wrote:

:REVIEWMAIL:

> Ok for the trunk and a week later for the 4.2 branch?

OK with a few minor comments.

> libgfortran/
> 2007-02-03  Thomas Koenig  <Thomas.Koenig@online.de>
> 	    Tobias Burnus  <burnus@net-b.de>
> 
>         PR fortran/30512
>         * m4/iparm.m4: Use HUGE-1 for most negative integer.
> 	* generated/maxloc1_4_r8.c: Regenerate.

You don't need to mention files like maxloc1_4_r8, which are
unchanged by this patch.  "svn status" gives you a list of changed
files, which you can then edit into your changelog entry.

> Index: gcc/testsuite/gfortran.dg/maxlocval.f90

To be consistent with the usual naming scheme, please use
maxlocval_1.f90.

Thanks!

	Thomas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]