This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gfortran,patch] Fix multiple evaluation of arg for REPEAT intrinsic

From: FX Coudert <fxcoudert at gmail dot com>
To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
Cc: "fortran at gcc dot gnu dot org List" <fortran at gcc dot gnu dot org>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
Date: Sun, 4 Feb 2007 22:34:18 +0100
Subject: Re: [gfortran,patch] Fix multiple evaluation of arg for REPEAT intrinsic
References: <67DCBC5F-B1D0-4850-81B9-55132993A213@gmail.com> <20070204205623.GA53667@troutmask.apl.washington.edu>

OK with some minor fixes.
+  arglist = gfc_chainon_list (arglist, TREE_VALUE(args));
+  arglist = gfc_chainon_list (arglist, TREE_VALUE(TREE_CHAIN(args)));
You're missing whitespace. These should be

+ arglist = gfc_chainon_list (arglist, TREE_VALUE (args)); + arglist = gfc_chainon_list (arglist, TREE_VALUE (TREE_CHAIN (args)));

Thanks for the review. Commited on mainline as rev. 121581.

FX

PS: :REVIEWMAIL:

References:
- [gfortran,patch] Fix multiple evaluation of arg for REPEAT intrinsic
  - From: FX Coudert
- Re: [gfortran,patch] Fix multiple evaluation of arg for REPEAT intrinsic
  - From: Steve Kargl

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]