Re: [patch] for gcc/testsuite/gcc.dg/builtin-apply4.c failure on x86 Mac OS

[Hui-May Chang <hm dot chang at apple dot com>]

On Jan 31, 2007, at 10:14 AM, Eric Christopher wrote:

> On Jan 31, 2007, at 9:16 AM, Hui-May Chang wrote:
>
> > On Jan 29, 2007, at 1:47 PM, Eric Christopher wrote:
> >
> > > > OK for mainline?
> > >
> > > Needs comments.
> > >
> > > -eric
> > The patch in ix86_function_arg_regno_p and  
> > ix86_function_value_regno_p changes  the number of registers used  
> > to pass function parameters, and the number of registers used to  
> > pass function return values. This violates the calling convention  
> > on x86 Mac OS platform, and binary compatibility  can no longer be  
> > maintained.
>
> You need comments in the patch about why we're doing something  
> different for OS X just like you'd comment any other piece of code.
>
> -eric
How about

Attachment: radar-patch.function.txt
Description: Text document

?