This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ipa-branch merge: Enable IPA-SSA


Jan Hubicka wrote on 01/01/07 12:45:

+ static unsigned int
+ execute_early_local_optimizations (void)
+ {
+ if (flag_unit_at_a_time)
+ cgraph_state = CGRAPH_STATE_IPA_SSA;
+ return 0;
+ }
+
Need comment before this function.

Index: passes.c
===================================================================
*** passes.c	(revision 120286)
--- passes.c	(working copy)
*************** init_optimization_passes (void)
*** 461,483 ****

Since you have probably changed the flow of activity from parsing to
optimization, the comment at the start of init_optimization_passes is
likely stale.

Could you fix the documentation at the top of the function and modify
the callgraph documentation in doc/?  It'd be nice to have a clear
picture of how compilation flows from parsing to the callgraph to
lowering and into the SSA passes.

In fact, it would be cool if we could get a Big Picture paper/talk about the whole callgraph/ipa harness at the next summit.


Thanks.




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]