This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fwd: [patch, libgomp, build] PR30546 build fail in libgomp when building from SVN because makeinfo is missing


Changes were applied to configure.ac, acinclude.m4 and Makefile.am, the
remaining changes are generated by autotools. Changes to Makefile.am are
messy and mostly copy-paste from gcc/Makefile.in. The macro AC_CHECK_PROG_VER
in acinclude.m4, is a cleaned-up copy of gcc_AC_CHECK_PROG_VER.

This part is fine, except that you should put it in config/acx.m4 and call it ACX_CHECK_PROG_VER (hoping to use it later in gcc too).

I think it is possible to obtain the same result with barely any Makefile.am hacking, using this in configure.ac:

AM_CONDITIONAL(BUILD_INFO, [test $gcc_cv_prog_makeinfo_modern = yes])

and this in Makefile.am:

if BUILD_INFO
info_TEXINFOS = libgomp.texi
endif

By the way, this is also wrong:

srcinfo: $(TEXI_LIBGOMP_FILES)
	-cp -p $^ $(srcdir)/libgomp.info

as it copies a texinfo file to an info file. (It is ok for the build to fail if there is no makeinfo and we request --enable-generated-files-in-srcdir).

Thanks,

Paolo

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]