This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [patch] tuning gcc for AMDFAM10 processor (patches 4 to 11)
- From: Roger Sayle <roger at eyesopen dot com>
- To: "Jagasia, Harsha" <harsha dot jagasia at amd dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 29 Jan 2007 21:48:22 -0700 (MST)
- Subject: RE: [patch] tuning gcc for AMDFAM10 processor (patches 4 to 11)
Hi Harsha,
On Mon, 29 Jan 2007, Jagasia, Harsha wrote:
> * gcc/gcc/config/i386/sse.md (cvtsi2ss, cvtsi2ssq,
> cvtss2si, cvtss2siq, cvttss2si, cvttss2siq,
> cvtsi2sd, cvtsi2sdq, cvtsd2si, cvtsd2siq,
> cvttsd2si, cvttsd2siq, cvtpd2dq, cvttpd2dq
> cvtsd2ss, cvtss2sd, cvtpd2ps, cvtps2pd):added
> amdfam10_decode attribute
The descriptive text in a ChangeLog entry should be a well-formed
sentence, i.e. start with a capital letter and end with a period/
full-stop. And in the example quoted above you need a space between
the colon and the first letter of the description. It seems that
the first patches in the series follow these GNU style guidelines,
but by the end the "added amdfam10" (which should be "Added amdfam10.")
seems to have become more prevalent.
> * gcc/gcc/config/i386/athlon.md (athlon_sseins_amdfam10
> ): new define_insn_reservation
>
> * gcc/gcc/config/i386/i38.md (sseins: added sseins to
> define_attr type and define_attr unit
In the first "entry", you should probably wrap the line after "):"
and in the second you're missing a close parenthesis after "sseins".
In both, the filenames should begin at "* config/i386/..." as the
filenames and paths in ChangeLog entries should be relative to the
ChangeLog itself. In this case, these are in gcc/gcc/ChangeLog.
Something like:
>> * config/i386/athlon.md (athlon_sseins_amdfam10):
>> New define_insn_reservation.
>>
>> * config/i386/i38.md (sseins): Added sseins to
>> define_attr type and define_attr unit.
These mistakes are repeated multiple times in your ChangeLog entries.
I hope this helps.
Roger
--